Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vender upgrade codedellemc/goscaleio to release v0.1.0 #80321

Merged
merged 1 commit into from Aug 7, 2019
Merged

vender upgrade codedellemc/goscaleio to release v0.1.0 #80321

merged 1 commit into from Aug 7, 2019

Conversation

Moriadry-zz
Copy link

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind bug
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #
fix #79234

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 18, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @moriadry. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 18, 2019
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jul 18, 2019
@Moriadry-zz
Copy link
Author

/assign @cblecker

@Moriadry-zz
Copy link
Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@moriadry: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2019
@Moriadry-zz
Copy link
Author

/retest

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 19, 2019
@Moriadry-zz
Copy link
Author

/retest

@dims
Copy link
Member

dims commented Jul 29, 2019

/area code-organization
/sig storage

@k8s-ci-robot k8s-ci-robot added the area/code-organization Issues or PRs related to kubernetes code organization label Jul 29, 2019
@dims
Copy link
Member

dims commented Jul 29, 2019

/kind cleanup
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 29, 2019
@dims
Copy link
Member

dims commented Jul 29, 2019

/assign @msau42 @saad-ali

Michelle, Saad,
Do we have any owners for this code?

@astripei70
Copy link

Hi,
The new location goscaleio location is https://github.com/dell/goscaleio
Also, VxFlexOS (aka ScaleIO) driver can be found here https://github.com/dell/csi-vxflexos.
Please feel free to reach me for any Dell EMC CSI related questions, queries or suggestions as I am a product manager for Dell EMC CSI drivers.

@msau42
Copy link
Member

msau42 commented Jul 30, 2019

@astripei70 thank you! Are you the right person to review this change to the in-tree scaleio plugin?

@saad-ali
Copy link
Member

Thanks @astripei70 can you verify that you are ok with this PR, if so we can go ahead and approve/merge it.

@astripei70
Copy link

@saad-ali technically https://github.com/thecodeteam/csi-scaleio repo is deprecated. It is out there only for the earlier released plugin. Any chance you could use https://github.com/dell/goscaleio instead?

@msau42
Copy link
Member

msau42 commented Jul 31, 2019

@astripei70 is it possible to find the owner of this plugin from your team to make the change?

@astripei70
Copy link

astripei70 commented Jul 31, 2019 •
edited

@msau42 We reviewed the changes and approve them. Appreciate your patience.

@msau42
Copy link
Member

msau42 commented Jul 31, 2019

@moriadry can you squash your commits?

/approve

@msau42
Copy link
Member

msau42 commented Jul 31, 2019

@astripei70 let's also work on getting members of your team memberships in kubernetes/kubernetes so that they can be the maintainers of this scaleio plugin.

@astripei70
Copy link

@msau42 Certainly, I could do this. Also, there is a discussion to deprecate in-tree ScaleIO driver 7fa6fc7
Perhaps this would eliminate the need to support goscaleio starting 1.16. Please advise.

@msau42 msau42 mentioned this pull request Jul 31, 2019
Closed
@msau42
Copy link
Member

msau42 commented Jul 31, 2019

@astripei70 i've opened up #80819 to continue discussion on this

@vladimirvivien vladimirvivien removed their assignment Jul 31, 2019
@vladimirvivien
Copy link
Member

/assign @astripei70

@moriadry
update codedellemc/goscaleio
bacda8a 
update thecodeteam/goscaleio

fix problem
@Moriadry-zz
Copy link
Author

@msau42 done

@vladimirvivien
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2019
@Moriadry-zz
Copy link
Author

Moriadry-zz commented Aug 4, 2019 •
edited

@vladimirvivien
Hi, what's going on now, Could you pls approve it?

@dims
Copy link
Member

dims commented Aug 5, 2019

/assign @liggitt @smarterclayton

Jordan, Clayton, this needs root approval. same license, repo moved.

@liggitt
Copy link
Member

liggitt commented Aug 6, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, Moriadry, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit e5862e7 into kubernetes:master Aug 7, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 7, 2019
@Moriadry-zz Moriadry-zz mentioned this pull request Aug 8, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@vladimirvivien vladimirvivien

@liggitt liggitt

@smarterclayton smarterclayton

@cblecker cblecker

@codenrhoden codenrhoden

@saad-ali saad-ali

@msau42 msau42

@astripei70 astripei70

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

Update vendored dependencies to a released version instead of random SHA(s)